Update default max publish batch byte size calculation - #36082
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @utsav-pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to enhance the robustness of the Apache Beam Java SDK's Pub/Sub integration by adjusting an internal default configuration. The modification ensures that the SDK's default batch size limit for publishing messages is consistent with the actual maximum message size supported by Google Cloud Pub/Sub. This prevents potential failures for users attempting to send larger, yet valid, messages, thereby improving the out-of-the-box experience.
Highlights
- Pub/Sub Batch Size Default: The default maximum publish batch byte size (MAX_PUBLISH_BATCH_BYTE_SIZE_DEFAULT) in PubsubIO.java has been updated.
- Alignment with Pub/Sub Limits: The default value is now 10MB, aligning with Google Cloud Pub/Sub's documented maximum message size, up from the previous 7.5MB.
- User Experience Improvement: This change prevents unexpected errors for users sending messages between 7.5MB and 10MB, allowing them to send messages up to the official 10MB limit without additional configuration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Unless the JSON client has been removed this limit can't be changed yet, see #31800 for details. TL;DR Base64 encoding outputs 4 bytes for 3 bytes of input, hence the 7.5MB limit, and the |
|
there are style errors: |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
3 participants
Addresses: #36067
Description:
This PR updates the default value of
MAX_PUBLISH_BATCH_BYTE_SIZE_DEFAULTinPubsubIO.javafrom 7.5MB (((10 * 1000 * 1000) / 4) * 3) to 10MB (10 * 1000 * 1000). This change aligns the Beam Java SDK's default Pub/Sub batch size limit with the documented Google Cloud Pub/Sub maximum message size, preventing unexpected failures when sending messages between 7.5MB and 10MB.Checklist:
CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.